Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented OW_IGNORE_EGGS_ON_HEAL #4888

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

pkmnsnfrn
Copy link
Collaborator

@pkmnsnfrn pkmnsnfrn commented Jun 30, 2024

Implemented https://github.com/pret/pokeemerald/wiki/Pokecenters-Disregard-Eggs with permission from @ghoulslash.

Description

I have added this as a gen toggle to mimic vanilla behavior. The default is Gen 3, as is currently customary. I also changed u8 and u16 to u32 in the functions that I touched.

Images

Old

old.mp4

New

new.mp4

The weird Pokeball showing up for a frame is related to followers.

People who collaborated with me in this PR

@ghoulslash

Discord contact info

pkmnsnfrn

@AlexOn1ine
Copy link
Collaborator

If this is a new gen behavior shouldn't it be set to latest?

@pkmnsnfrn
Copy link
Collaborator Author

If this is a new gen behavior shouldn't it be set to latest?

9ca4a23

Fixed spelling error per rh-hideout#4888 (comment)

Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
@AlexOn1ine AlexOn1ine merged commit 2a5e434 into rh-hideout:upcoming Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants